CMake export target fix #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frankosterfeld Will you have time to look into this? Otherwise I consider to propose this as a patch for vcpkg, which is using the main branch currently. |
|
I will no start to propose a patched version to vcpkg. |
|
Sorry for the delay, merging now |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improved fix for the #209
It turns out that the solution implemented in #210 dos not work because instead of the CMAKE_CONFIG_TYPE of the target project the first found config type is used which is likely "Debug".
The other issue was that the "fix"
for treating QTKEYCHAIN_LIBRARIES as import targets was actually required to link against the import lib instead of the dll on windows. It has been (mis-)used to link against the imported target qtkeychain/qt5keyhain/qt6keychain.
I have also noted that the check_required_components() call for setting the _FOUND variable was missing.
This is fixed as well.
Now everything works again on windows and macOS checked here:
https://github.com/daschuer/mixxx/actions/runs/2288987143